Foscam Camera: Adding exception handling when fetching the camera image to avoid python exception errors when host is not reachable or rather any url error to camera #6964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hon errors when host is not reachable or any url errors to camera
|
@viswa-swami, thanks for your PR! By analyzing the history of the files in this pull request, we identified @heathbar, @fabaff and @balloob to be potential reviewers. |
|
Hi @viswa-swami, It seems you haven't yet signed a CLA. Please do so here. Once you do that we will be able to review and accept this pull request. Thanks! |
…he unused error handle
|
I think you should add a logging.waring to info the user that we "lost" a picture. |
|
Just wondering, Is that really required to log, because what we are doing
for a camera is basically streaming the content. Of course, depends on the
use of camera, but what purpose would that solve if we log the message?
Will user really benefit from a message that we lost one frame when the
next frame might work properly and user might be able to see the content
via hass.
…On Thu, Apr 6, 2017 at 3:32 PM Pascal Vizeli ***@***.***> wrote:
I think you should add a logging.waring to info the user that we "lost" a
picture.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#6964 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AGrhc_rIiBPKT3PYy1lYPsD9eHzemU_6ks5rtT2ygaJpZM4M1_L3>
.
|
|
Moreover, one use case is that, the camera could potentially be off when the user is at home for privacy reasons, and will only be armed when user is away. So, during the entire period when camera is off, communication will fail, during which time, log will again be filled with this 'lost a picture' message. |
balloob
pushed a commit
that referenced
this pull request
Apr 8, 2017
…ge to avoid python exception errors when host is not reachable or rather any url error to camera (#6964) * Adding exception handling when fetching the camera image to avoid python errors when host is not reachable or any url errors to camera * Added exception as ConnectionError instead of plain except * Added exception as ConnectionError instead of plain except. Removed the unused error handle
|
Cherry-picked into the 0.42 branch |
Merged
|
Thank you for including this fix into the 0.42 release.
…On Sat, Apr 8, 2017, 07:55 Paulus Schoutsen ***@***.***> wrote:
Cherry-picked into the 0.42 branch
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#6964 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AGrhc0D4lEbypAxKzb_tH8i-9xrVGdQ_ks5rt3W-gaJpZM4M1_L3>
.
|
Merged
ghost
added
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Added exception handling for the requests.get call in the foscam camera component. Earlier code was just trying to get the image from the camera url directly and without checking for response validity, just returns the response back to the parent caller. This caused the requests.get() to fail when host is not reachable. Added the exception handling around the requests.get() call.
Related issue (if applicable): fixes #6962
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#<home-assistant.github.io PR number goes here>
Example entry for
configuration.yaml(if applicable):Checklist:
If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
toxrun successfully. Your PR cannot be merged unless tests passREQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.If the code does not interact with devices:
toxrun successfully. Your PR cannot be merged unless tests pass