Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Xiaomi Miio fan config flow #46866

Merged
merged 11 commits into from
Feb 25, 2021

Conversation

starkillerOG
Copy link
Contributor

@starkillerOG starkillerOG commented Feb 21, 2021

Breaking change

The Xiaomi Miio Fan platform now uses Config Flow, the old yaml config is imported to a Config Entry, please remove the yaml config once you see the Loading Xiaomi Miio Fan via platform setup is deprecated. Please remove it from your configuration. warning in the log.

Proposed change

Add config flow for the Xiaomi Miio Fan platform

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

Config Flow

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

This pull request needs to be manually signed off by @home-assistant/core before it can get merged.
(message by ReviewEnforcer)

@probot-home-assistant
Copy link

Hey there @rytilahti, @syssi, mind taking a look at this pull request as its been labeled with an integration (xiaomi_miio) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@bdraco
Copy link
Member

bdraco commented Feb 21, 2021

Not a requirement for this PR, but this integration should get updated to the new fan entity model at some point https://developers.home-assistant.io/docs/core/entity/fan

@starkillerOG
Copy link
Contributor Author

@bdraco thanks for the input!
However I am currently only converting all Miio platforms to Config Flow, so the fan entity model is indeed out of scope for this PR.
All services accross the Miio integration schould also be updated to Entity services at some point.

@starkillerOG
Copy link
Contributor Author

@MartinHjelmare Could you also revieuw this Xiaomi Miio Fan config flow (since you did the other Miio config flows)?

@bieniu
Copy link
Member

bieniu commented Feb 22, 2021

Shouldn't humidifiers use a humidifier platform instead of a fan platform?

@syssi
Copy link
Member

syssi commented Feb 22, 2021

@bieniu You are totally right but this isn't the scope of this PR.

homeassistant/components/xiaomi_miio/fan.py Outdated Show resolved Hide resolved
homeassistant/components/xiaomi_miio/fan.py Outdated Show resolved Hide resolved
homeassistant/components/xiaomi_miio/fan.py Outdated Show resolved Hide resolved
homeassistant/components/xiaomi_miio/fan.py Outdated Show resolved Hide resolved
homeassistant/components/xiaomi_miio/fan.py Outdated Show resolved Hide resolved
homeassistant/components/xiaomi_miio/fan.py Outdated Show resolved Hide resolved
@starkillerOG
Copy link
Contributor Author

@MartinHjelmare thanks for the feedback

Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MartinHjelmare MartinHjelmare merged commit 7dc9071 into home-assistant:dev Feb 25, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Feb 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants