-
-
Notifications
You must be signed in to change notification settings - Fork 30.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Xiaomi Miio fan config flow #46866
Add Xiaomi Miio fan config flow #46866
Conversation
This pull request needs to be manually signed off by @home-assistant/core before it can get merged. |
Hey there @rytilahti, @syssi, mind taking a look at this pull request as its been labeled with an integration ( |
Not a requirement for this PR, but this integration should get updated to the new fan entity model at some point https://developers.home-assistant.io/docs/core/entity/fan |
@bdraco thanks for the input! |
@MartinHjelmare Could you also revieuw this Xiaomi Miio Fan config flow (since you did the other Miio config flows)? |
Shouldn't humidifiers use a humidifier platform instead of a fan platform? |
@bieniu You are totally right but this isn't the scope of this PR. |
Co-authored-by: Martin Hjelmare <[email protected]>
Co-authored-by: Martin Hjelmare <[email protected]>
Co-authored-by: Martin Hjelmare <[email protected]>
Co-authored-by: Martin Hjelmare <[email protected]>
Co-authored-by: Martin Hjelmare <[email protected]>
@MartinHjelmare thanks for the feedback |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Breaking change
The Xiaomi Miio Fan platform now uses Config Flow, the old yaml config is imported to a Config Entry, please remove the yaml config once you see the
Loading Xiaomi Miio Fan via platform setup is deprecated. Please remove it from your configuration.
warning in the log.Proposed change
Add config flow for the Xiaomi Miio Fan platform
Type of change
Example entry for
configuration.yaml
:Config Flow
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: