Add yamaha_musiccast sound modes

[uvjustin]

Description:

Added sound modes to yamaha-musiccast component. @jalmeroth

Checklist:

• [x ] The code change is tested and works locally.

[homeassistant]

Hi @uvjustin,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

[probot-home-assistant]

Hey there @jalmeroth, mind taking a look at this pull request as its been labeled with a integration (yamaha_musiccast) you are listed as a codeowner for? Thanks!

[springstan]

@uvjustin please solve all CI errors by following the development checklist:)

[uvjustin]

Just ran black (it corrected import order and added newline at the end). However, the change here was minimal - most of the changes are actually in the PYPI library, and the requirements won't be satisfied until that package is reviewed/updated by the maintainer.
I'm new to Github so let me know if you have any pointers about how to contribute/collaborate. (I have a contribution to a different integration ready, but I'll wait to push it until I get more familiar with this process.)

[frenck]

@uvjustin From this end, it looks like the formatting with black is the only apparent issue for the CI to pass at this point. Format it, commit it, push it, and see how far the build will go after that. 👍

[springstan]

@uvjustin any updates on this? :)

[uvjustin]

@springstan
I'm not the package maintainer of the pypi package so we'll have to wait for my pull request to get merged on that side.

[springstan]

@uvjustin please link the PR that needs to be merged in the python package and please format your code with black and push it so we can take a look at it :)

[uvjustin]

@springstan Here is the PR jalmeroth/pymusiccast#15

[stale]

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
Thank you for your contributions.

[uvjustin]

Ok with closing this. I will continue to use my own version locally for the sound modes functionality. If there's more interest in updating the pymusiccast library I can fork it and update the HA core to use that library instead.

[MartinHjelmare]

I'll close here since this is still waiting for upstream.

[TheZoker]

@uvjustin please fork the library and redo this PR. I have two Yamaha musiccast speakers and am waiting for this PR