Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for for to binary_sensor, light and switch device triggers #26658

Merged
merged 11 commits into from
Oct 2, 2019
Merged

Add support for for to binary_sensor, light and switch device triggers #26658

merged 11 commits into from
Oct 2, 2019

Conversation

emontnemery
Copy link
Contributor

@emontnemery emontnemery commented Sep 15, 2019 •
edited
Loading

Description:

Add support for for to binary_sensor, light and switch device triggers.
Add WS API device_automation/trigger/capabilities

Depends on home-assistant-libs/voluptuous-serialize#9

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@emontnemery emontnemery requested a review from a team as a code owner September 15, 2019 07:48
@emontnemery emontnemery mentioned this pull request Sep 15, 2019
Closed
@emontnemery emontnemery force-pushed the device_automation_trigger_for branch from afdbcf1 to 738d10e Compare September 15, 2019 08:20
@emontnemery emontnemery changed the title WIP: Add support for for to switch and light device automation triggers Add support for for to switch and light device automation triggers Sep 17, 2019
@balloob
Copy link
Member

balloob commented Sep 21, 2019

How will we deal with this in the frontend ?

@emontnemery
Copy link
Contributor Author

@balloob frontend pr: home-assistant/frontend#3721

@emontnemery emontnemery force-pushed the device_automation_trigger_for branch from 152d87a to 376b4dd Compare September 28, 2019 08:52
@emontnemery emontnemery changed the title Add support for for to switch and light device automation triggers Add support for for to binary_sensor, light and switch device triggers Sep 28, 2019
@emontnemery emontnemery force-pushed the device_automation_trigger_for branch from 79d70b1 to 4cec102 Compare October 2, 2019 16:57
@emontnemery emontnemery merged commit 65ce3b4 into home-assistant:dev Oct 2, 2019
@emontnemery emontnemery deleted the device_automation_trigger_for branch October 3, 2019 16:37
@lock lock bot locked and limited conversation to collaborators Oct 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@balloob balloob balloob approved these changes

@Adminiuga Adminiuga Awaiting requested review from Adminiuga Adminiuga is a code owner

@dmulcahey dmulcahey Awaiting requested review from dmulcahey dmulcahey is a code owner

@Kane610 Kane610 Awaiting requested review from Kane610 Kane610 is a code owner

Assignees
No one assigned
Labels
cla-signed integration: device_automation small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emontnemery @balloob @homeassistant