Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle on/off through TemperatureSetting trait #21842

Merged
merged 1 commit into from
Mar 21, 2019

Conversation

Swamp-Ig
Copy link
Contributor

@Swamp-Ig Swamp-Ig commented Mar 9, 2019

Description:

For climate(in HA)/thermostat (in GA), the reccomended traits are the TemperatureSetting trait only, and not the OnOff trait.

GA actually completely ignores the OnOff trait, and will process "turn on " and "turn off " commands only through the TemperatureSetting trait.

I have fixed this by removing climate from OnOff, and passing on turn on / off properly (by calling the turn_on and turn_off services).

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@ghost ghost assigned Swamp-Ig Mar 19, 2019
@Swamp-Ig Swamp-Ig requested a review from balloob March 19, 2019 10:14
@balloob balloob merged commit 81bb928 into home-assistant:dev Mar 21, 2019
@ghost ghost removed the in progress label Mar 21, 2019
@Swamp-Ig Swamp-Ig deleted the climate-on-off branch March 23, 2019 11:53
@balloob balloob mentioned this pull request Apr 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants