Fix owntracks topic in encrypted ios #19220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
homeassistant
added
integration: device_tracker
integration: owntracks
core
small-pr
ghost
assigned 
bramkragten
approved these changes
Dec 12, 2018
balloob
added a commit
that referenced
this pull request
Dec 12, 2018
* Fix owntracks topic * Warn if per-topic secret and using HTTP
Merged
|
I bet this is my problem! For my debug attempt I decrypted it. |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
On iOS, the encrypted payload does not contain a topic. It is available in the decrypted payload.
This adjusts the check to not throw away the message if it's encrypted but process it instead. It will still attach the topic on encrypted messages if it's able to derive it from the Android headers (as Android never includes
topic)Thanks to @arsaboo and @bramkragten for helping with testing
Related issue (if applicable): fixes #18927
Checklist:
tox. Your PR cannot be merged unless tests passIf the code does not interact with devices: