Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cloud defaults #19172

Merged
merged 1 commit into from
Dec 11, 2018
Merged

Fix cloud defaults #19172

merged 1 commit into from
Dec 11, 2018

Conversation

balloob
Copy link
Member

@balloob balloob commented Dec 10, 2018

Description:

Fix cloud defaults, it's causing confusion and support tickets.

Related issue (if applicable): fixes #

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@balloob balloob added this to the 0.84.0 milestone Dec 10, 2018
@balloob balloob requested a review from a team as a code owner December 10, 2018 22:09
@ghost ghost assigned balloob Dec 10, 2018
@ghost ghost added the in progress label Dec 10, 2018
@balloob balloob merged commit 557720b into dev Dec 11, 2018
@ghost ghost removed the in progress label Dec 11, 2018
@delete-merged-branch delete-merged-branch bot deleted the cloud-defaults branch December 11, 2018 05:50
balloob added a commit that referenced this pull request Dec 11, 2018
@balloob balloob mentioned this pull request Dec 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants