Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump skybellpy version to fix api issue #19100

Merged
merged 1 commit into from
Dec 7, 2018

Conversation

nhorvath
Copy link
Contributor

@nhorvath nhorvath commented Dec 7, 2018

Description:

Increase skybellpy version number to version with fixes for API changes.

Related issue (if applicable): fixes #
fixes #17617

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>
n/a

Example entry for configuration.yaml (if applicable):

n/a

Checklist:

  • [ x ] The code change is tested and works locally.
  • [ x ] Local tests pass with tox. Your PR cannot be merged unless tests pass
  • [ x ] There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • [ x ] New dependencies have been added to the REQUIREMENTS variable (example).
  • [ x ] New dependencies are only imported inside functions that use them (example).
  • [ x ] New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • [ x ] New files were added to .coveragerc.

If the code does not interact with devices:

  • [ x ] Tests have been added to verify that the new code works.

@ghost ghost added the in progress label Dec 7, 2018
@nhorvath
Copy link
Contributor Author

nhorvath commented Dec 7, 2018

@MartinHjelmare any chance this could get pulled into 0.84? It's just a dependency bump (and no changes in upstream deps from that). Thanks!

@MartinHjelmare MartinHjelmare added this to the 0.84.0 milestone Dec 7, 2018
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be merged when build passes.

@MisterWil MisterWil mentioned this pull request Dec 7, 2018
@nhorvath
Copy link
Contributor Author

nhorvath commented Dec 7, 2018

@MartinHjelmare one of the build steps failed, but it seems unrelated. Can you take a look? Thank you.

@MartinHjelmare
Copy link
Member

That's a flaky test. Merging.

@MartinHjelmare MartinHjelmare merged commit e567e3d into home-assistant:dev Dec 7, 2018
@ghost ghost removed the in progress label Dec 7, 2018
@nhorvath nhorvath deleted the skybellpy branch December 7, 2018 18:21
@balloob balloob mentioned this pull request Dec 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Skybell HD Camera
4 participants