Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Tibber lib #19098

Merged
merged 1 commit into from
Dec 7, 2018
Merged

Upgrade Tibber lib #19098

merged 1 commit into from
Dec 7, 2018

Conversation

Danielhiversen
Copy link
Member

@Danielhiversen Danielhiversen commented Dec 7, 2018 •
edited
Loading

Description:

https://github.com/Danielhiversen/pyTibber/commits/master
Will fix a connection issue for Tibber Pulse

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable ([example][ex-requir]).
  • New dependencies are only imported inside functions that use them ([example][ex-import]).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

@Danielhiversen Danielhiversen added this to the 0.84.0 milestone Dec 7, 2018
@ghost ghost assigned Danielhiversen Dec 7, 2018
@ghost ghost added the in progress label Dec 7, 2018
@Danielhiversen Danielhiversen merged commit a58b3aa into dev Dec 7, 2018
@delete-merged-branch delete-merged-branch bot deleted the tibber_lib_upgrade branch December 7, 2018 18:33
@ghost ghost removed the in progress label Dec 7, 2018
balloob pushed a commit that referenced this pull request Dec 10, 2018
@Danielhiversen @balloob
Upgrade Tibber lib (#19098)
e6c224f
@balloob balloob mentioned this pull request Dec 12, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartinHjelmare MartinHjelmare MartinHjelmare approved these changes

Assignees

@Danielhiversen Danielhiversen

Labels
cherry-picked cla-signed integration: tibber small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
0.84.0
Development

Successfully merging this pull request may close these issues.
4 participants
@Danielhiversen @MartinHjelmare @balloob @homeassistant