Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force refresh Lovelace #19073

Merged
merged 4 commits into from
Dec 7, 2018
Merged

Force refresh Lovelace #19073

merged 4 commits into from
Dec 7, 2018

Conversation

bramkragten
Copy link
Member

Description:

home-assistant/frontend#2200

Related issue (if applicable): fixes #

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@bramkragten bramkragten requested a review from a team as a code owner December 6, 2018 20:22
@ghost ghost assigned bramkragten Dec 6, 2018
@ghost ghost added the in progress label Dec 6, 2018
@homeassistant homeassistant added integration: lovelace small-pr PRs with less than 30 lines. labels Dec 6, 2018
@bramkragten bramkragten added this to the 0.84.0 milestone Dec 6, 2018
@@ -158,23 +159,31 @@ def load_config(hass) -> JSON_TYPE:
config = yaml.load_yaml(fname, False)
seen_card_ids = set()
seen_view_ids = set()
if 'views' in config and not isinstance(config['views'], list):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All this code… that's kinda why we have voluptuous 😛

@ghost ghost assigned balloob Dec 7, 2018
@balloob balloob merged commit 455508d into dev Dec 7, 2018
@delete-merged-branch delete-merged-branch bot deleted the ll-force-refresh branch December 7, 2018 06:09
@ghost ghost removed the in progress label Dec 7, 2018
balloob pushed a commit that referenced this pull request Dec 7, 2018
* Force refresh Lovelace

* Check config on load

* Update __init__.py

* Update __init__.py
@balloob balloob mentioned this pull request Dec 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants