Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CI by pinning IDNA #19038

Merged
merged 2 commits into from
Dec 5, 2018
Merged

Fix CI by pinning IDNA #19038

merged 2 commits into from
Dec 5, 2018

Conversation

balloob
Copy link
Member

@balloob balloob commented Dec 5, 2018

Description:

IDNA released 2.8. Requests caps IDNA at <2.8 which causes CI to break. Attempt to pin it.

@homeassistant homeassistant added core small-pr PRs with less than 30 lines. cla-signed labels Dec 5, 2018
@ghost ghost assigned balloob Dec 5, 2018
@ghost ghost added the in progress label Dec 5, 2018
@balloob balloob requested a review from a team as a code owner December 5, 2018 12:33
@fabaff fabaff mentioned this pull request Dec 5, 2018
Closed
3 tasks
@balloob balloob merged commit 0e9e253 into dev Dec 5, 2018
@delete-merged-branch delete-merged-branch bot deleted the fix-idna-build branch December 5, 2018 13:43
@ghost ghost removed the in progress label Dec 5, 2018
@balloob balloob mentioned this pull request Dec 12, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@balloob balloob

Labels
cla-signed core small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@balloob @homeassistant