Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow checking entity permissions based on devices #19007

Merged
merged 2 commits into from
Dec 5, 2018
Merged

Allow checking entity permissions based on devices #19007

merged 2 commits into from
Dec 5, 2018

Conversation

balloob
Copy link
Member

@balloob balloob commented Dec 4, 2018

Description:

Add support for checking entity permissions based on device they belong to.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@balloob balloob requested a review from a team as a code owner December 4, 2018 14:47
@ghost ghost assigned balloob Dec 4, 2018
@ghost ghost added the in progress label Dec 4, 2018
@balloob
Copy link
Member Author

balloob commented Dec 4, 2018

After this commit it's time we create some bad ass UI for it 😎

@pvizeli pvizeli merged commit 3928d03 into dev Dec 5, 2018
@ghost ghost removed the in progress label Dec 5, 2018
@delete-merged-branch delete-merged-branch bot deleted the permissions-dev-reg branch December 5, 2018 10:41
@balloob balloob mentioned this pull request Dec 12, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pvizeli pvizeli pvizeli approved these changes

Assignees

@balloob balloob

Labels
cla-signed core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@balloob @pvizeli @homeassistant