Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for multiple RainMachine controllers #18989

Merged
merged 7 commits into from
Dec 5, 2018
Merged

Add support for multiple RainMachine controllers #18989

merged 7 commits into from
Dec 5, 2018

Conversation

bachya
Copy link
Contributor

@bachya bachya commented Dec 3, 2018 •
edited
Loading

Description:

Even though multiple RainMachine controllers can be added via config UI, the same use case can't be accommodated via configuration.yaml. This PR rectifies that.

BREAKING CHANGE: the configuration.yaml format changes to the below.

Related issue (if applicable): N/A

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#7721

Example entry for configuration.yaml (if applicable):

rainmachine:
  controllers:
    - ip_address: !secret rainmachine_ip_address
      password: !secret rainmachine_password

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

@bachya bachya self-assigned this Dec 3, 2018
@ghost ghost added the in progress label Dec 3, 2018
@bachya bachya mentioned this pull request Dec 3, 2018
Merged
2 tasks
@bachya bachya force-pushed the multiple-rainmachine branch from e1df665 to 9f93076 Compare December 5, 2018 14:29
MartinHjelmare
MartinHjelmare approved these changes Dec 5, 2018
View reviewed changes
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Can be merged when build passes.

@bachya bachya merged commit 0870254 into home-assistant:dev Dec 5, 2018
@ghost ghost removed the in progress label Dec 5, 2018
@bachya bachya deleted the multiple-rainmachine branch December 5, 2018 17:32
@balloob balloob mentioned this pull request Dec 12, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@houndci-bot houndci-bot houndci-bot left review comments

@MartinHjelmare MartinHjelmare MartinHjelmare approved these changes

Assignees

@bachya bachya

Labels
breaking-change cla-signed integration: rainmachine
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bachya @MartinHjelmare @houndci-bot @homeassistant