Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VOC: minor update #18967

Merged
merged 1 commit into from
Dec 3, 2018
Merged

VOC: minor update #18967

merged 1 commit into from
Dec 3, 2018

Conversation

molobrakos
Copy link
Contributor

Description:

  • Update library version.
  • Moved method one step out
  • Instruments can be a set as well

Related issue (if applicable): fixes #

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@ghost ghost assigned molobrakos Dec 3, 2018
@ghost ghost added in progress and removed integration: volvooncall small-pr PRs with less than 30 lines. labels Dec 3, 2018
@MartinHjelmare MartinHjelmare merged commit d7a1013 into home-assistant:dev Dec 3, 2018
@ghost ghost removed the in progress label Dec 3, 2018
@molobrakos molobrakos deleted the voc branch December 3, 2018 19:32
@balloob balloob mentioned this pull request Dec 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants