Event not JSON serializable - Recorder #18919
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Not all events JSON serializable. This mainly applies to service_call events for which
templates
aren't rendered yet. Since thetemplate
doesn't have knowledge ofhass
yet (at the moment of the service_call), it can't render itself either. See the issue linked below for an example.Originally I though of rendering it after the serialization failed (a00bd34), but I think that would overly complicate things. That's why I would propose changing the
warning
message to adebug
one.A assume similar chases would apply from
States
.Related issue (if applicable): fixes #18900
Checklist:
tox
. Your PR cannot be merged unless tests pass