-
-
Notifications
You must be signed in to change notification settings - Fork 32k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use capability of sensor if present to fix multisensor Wink devices #18907
Conversation
Any user with these devices won't be able to use them. What is the process for getting this fix in the next hotfix? |
To get it into a hotfix, it needs to be tagged with the milestone, which I just did for you 👍 |
aefb465
to
d851416
Compare
I think this was a breaking change. My Wink sensors had a new ID of _2. Easily fixed with a search and replace but all the automations related to the Wink sensors broke. |
@CCOSTAN You are correct, it was a breaking change. I wasn't aware of it at the time however due to running a seperate dev instance to implement the fix. Really the first change caused a problem which couldn't be corrected without breaking things. I am not sure how something like this should have been handled. For a user that isn't aware of the .storage directory. Which really no one should be aware of it, they wouldn't know what to do. @balloob How should something like this be fixed? For the non-technical user (not sure we have too many at this point) this kind of issue would be very frustrating since the core.entity_registry shouldn't be manually modified. It's almost like we need an upgrade processes that can "fix" things if version was X and then Y. However I am sure that would be a nightmare to maintain. |
@w1ll1am23 For my part, the fix was super easy AND super easy to see. When I upgraded, the new sensors floated to the top as badges (I'm not at Lovelace yet). It was apparent that the new IDs had _2. I just did a mass search and replace to correct all automations pointing to the old reference. |
@CCOSTAN so you just updated your automations to use the _2? To fix my prod HA I deleted all of the wink entities from the entity registry so I didn't have to update any automations. |
@w1ll1am23 Originally, that was the plan but I decided to clean up the names a bit (and have them saved in the entity registry). So I basically gave them new names and then updated all automations. You can see the changes here. |
Description:
Unique ID support was added, but didn't account for Wink devices that are broken out in to several sensors in HA. For example the Wink relay and Wink smoke detectors which show up in Home Assistant as multiple sensors even though they are only one device.
Related issue (if applicable): fixes https://community.home-assistant.io/t/wink-relay-problem-after-upgrade/82269
Checklist:
tox
. Your PR cannot be merged unless tests pass