BUGFIX: handle extra fan speeds. #18799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
homeassistant
added
integration: google_assistant
core
small-pr
ghost
added
the
marchingphoenix
changed the title
balloob
reviewed
Nov 29, 2018
| @@ -717,7 +717,7 @@ def sync_attributes(self): | |||
| speed = { | |||
| "speed_name": mode, | |||
| "speed_values": [{ | |||
| "speed_synonym": self.speed_synonyms.get(mode), | |||
There was a problem hiding this comment.
if the mode is not one of our official supported ones, we should ignore it.
Remove catch all, drop missing fan speeds.
houndci-bot
reviewed
Nov 29, 2018
balloob
approved these changes
Nov 29, 2018
balloob
pushed a commit
that referenced
this pull request
Nov 29, 2018
* BUGFIX: add support for extra fan speeds. * Drop extra fan speeds. Remove catch all, drop missing fan speeds. * fix self.speed_synonyms call. Remove un-needed keys() call
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
mqtt and zha fans either have or can have extra speed modes other than the default 4 [off, low, medium, high]
When these are present, it was breaking the payload sent to GA.
Added support for these additional speeds but they will not have additional aliases.
Related issue (if applicable): fixes #18798
**Pull request in home-assistant.io with documentation (if applicable): Not Applicable
Example entry for
configuration.yaml(if applicable):Not Applicable
Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
Not applicable
If the code communicates with devices, web services, or third-party tools:
REQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.Not applicable
If the code does not interact with devices: