-
-
Notifications
You must be signed in to change notification settings - Fork 31.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tellduslive refactoring #18780
Tellduslive refactoring #18780
Conversation
@molobrakos, what is your take do you still want to be part in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's use of async_add_job
from sync context in the component. That should be updated to probably use add_job
.
There's also a case where we register a listener for home assistant start event if session is not truthy which doesn't seem possible.
@fredrike: feel free to remove me. I already believe you also have write persmissions to the tellduslive library, right? Maybe that has to be refactored to use asyncio as well (aiohttp instead of requests)? (edit: ah, I now see that you run the updated outside of the main loop for now) |
726a4e8
to
295aa29
Compare
@MartinHjelmare ping 😃 . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Description:
Move component to package and refactoring.
Related issue (if applicable): fixes #17515
Checklist:
tox
. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
REQUIREMENTS
variable (example).requirements_all.txt
by runningscript/gen_requirements_all.py
..coveragerc
.If the code does not interact with devices: