Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tellduslive refactoring #18780

Merged
merged 7 commits into from
Dec 4, 2018

Conversation

fredrike
Copy link
Contributor

Description:

Move component to package and refactoring.

Related issue (if applicable): fixes #17515

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@fredrike
Copy link
Contributor Author

@molobrakos, what is your take do you still want to be part in CODEOWNER (automatically tagged for issues and reviewing)?

Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's use of async_add_job from sync context in the component. That should be updated to probably use add_job.

There's also a case where we register a listener for home assistant start event if session is not truthy which doesn't seem possible.

homeassistant/components/tellduslive/entry.py Outdated Show resolved Hide resolved
homeassistant/components/tellduslive/entry.py Outdated Show resolved Hide resolved
homeassistant/components/tellduslive/entry.py Outdated Show resolved Hide resolved
@molobrakos
Copy link
Contributor

molobrakos commented Nov 30, 2018

@molobrakos, what is your take do you still want to be part in CODEOWNER (automatically tagged for issues and reviewing)?

@fredrike: feel free to remove me. I already believe you also have write persmissions to the tellduslive library, right? Maybe that has to be refactored to use asyncio as well (aiohttp instead of requests)? (edit: ah, I now see that you run the updated outside of the main loop for now)

@fredrike fredrike force-pushed the tellduslive-refactor branch from 726a4e8 to 295aa29 Compare November 30, 2018 19:51
@fredrike
Copy link
Contributor Author

fredrike commented Dec 4, 2018

@MartinHjelmare ping 😃 .

Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@MartinHjelmare MartinHjelmare merged commit d6a4e10 into home-assistant:dev Dec 4, 2018
@ghost ghost removed the in progress label Dec 4, 2018
@balloob balloob mentioned this pull request Dec 12, 2018
@fredrike fredrike deleted the tellduslive-refactor branch February 11, 2019 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tellduslive fails after upgrade to 0.80.1
4 participants