Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change state case for rtorrent #18778

Merged
merged 1 commit into from
Dec 1, 2018

Conversation

eliseomartelli
Copy link
Contributor

@eliseomartelli eliseomartelli commented Nov 29, 2018

Description:

Fixed the case of sensor.rtorrent

Breaking changes:

Changed the returned states of sensor.rtorrent from Up/Down,
Downloading and Seeding to up_down, downloading and seeding to
reflect the guidelines. Hence by automations relying on the state of this
sensor should be updated.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

@ghost ghost added the in progress label Nov 29, 2018
@fabaff fabaff changed the title fixed state case for rtorrent Fixed state case for rtorrent Nov 29, 2018
@fabaff fabaff changed the title Fixed state case for rtorrent Change state case for rtorrent Nov 29, 2018
@fabaff
Copy link
Member

fabaff commented Nov 29, 2018

This requires a paragraph for the release notes as it's a breaking change.

@eliseomartelli
Copy link
Contributor Author

@fabaff where I can provide them?

@fabaff
Copy link
Member

fabaff commented Nov 29, 2018

As comment.

@eliseomartelli
Copy link
Contributor Author

eliseomartelli commented Nov 29, 2018 via email

Copy link
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐦

@fabaff fabaff merged commit c69fe43 into home-assistant:dev Dec 1, 2018
@ghost ghost removed the in progress label Dec 1, 2018
@balloob balloob mentioned this pull request Dec 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants