Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sporadic test failure for test_initialize_from_database_with_maxage #18756

Merged
merged 1 commit into from
Nov 28, 2018
Merged

Fix sporadic test failure for test_initialize_from_database_with_maxage #18756

merged 1 commit into from
Nov 28, 2018

Conversation

ehendrix23
Copy link
Contributor

Description:

Fix for sporadic test failure of test test_initialize_from_database_with_maxage in test_statistics

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

@ehendrix23
Add block after setting up component
6adf6fc 
Added a block_till_done after setting up component and before starting HASS.
@homeassistant homeassistant added small-pr PRs with less than 30 lines. cla-signed labels Nov 28, 2018
@ghost ghost added the in progress label Nov 28, 2018
@balloob balloob merged commit 0bdf96d into home-assistant:dev Nov 28, 2018
@balloob
Copy link
Member

balloob commented Nov 28, 2018

🎉

@ghost ghost removed the in progress label Nov 28, 2018
@ehendrix23 ehendrix23 deleted the Fix-sporadic-test-failure-in-test_initialize_from_database_with_maxage branch November 28, 2018 17:46
@balloob balloob mentioned this pull request Dec 12, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla-signed small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ehendrix23 @balloob @homeassistant