Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce permissions for Websocket API #18719

Merged
merged 2 commits into from
Nov 27, 2018
Merged

Enforce permissions for Websocket API #18719

merged 2 commits into from
Nov 27, 2018
+81 −17

Conversation

balloob
Copy link
Member

@balloob balloob commented Nov 26, 2018

Description:

Enforce permissions for websocket API.

For now I have made subscribe_events require admin. In the future will come up with some whitelist for events that are ok to listen to.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@ghost ghost assigned balloob Nov 26, 2018
@ghost ghost added the in progress label Nov 26, 2018
@balloob balloob merged commit 9d7b1fc into dev Nov 27, 2018
@ghost ghost removed the in progress label Nov 27, 2018
@balloob balloob deleted the perm-ws branch November 27, 2018 09:12
@balloob balloob mentioned this pull request Dec 12, 2018
Merged
@sysrun sysrun mentioned this pull request Dec 12, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@balloob balloob

Labels
cla-signed core integration: websocket_api
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@balloob @homeassistant