-
-
Notifications
You must be signed in to change notification settings - Fork 32k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update of volvooncall component #18702
Conversation
ad82bee
to
c7d441c
Compare
c9186a8
to
259627e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! Let me know when it's out of WIP, and I'll take a final look.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice! Can be merged when last comment is addressed, build passes and docs PR is linked in description.
What about |
Until we implement config entries for volvooncall, or explicitly remove entities, |
For future PRs, to make it easier for readers to track changes, please don't squash after review has started. We will squash when we merge. |
mutable=config[DOMAIN][CONF_MUTABLE], | ||
scandinavian_miles=config[DOMAIN][CONF_SCANDINAVIAN_MILES]) | ||
|
||
def is_enabled(attr): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like, we could move this out one level, so that's it not defined each time we run discover_vehicle
.
We can clean that up later, if wanted. |
Description:
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#7647
Example entry for
configuration.yaml
(if applicable):Checklist:
tox
. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
REQUIREMENTS
variable ([example][ex-requir]).requirements_all.txt
by runningscript/gen_requirements_all.py
..coveragerc
.