Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow managing cloud webhook #18672

Merged
merged 16 commits into from
Nov 26, 2018
Merged

Allow managing cloud webhook #18672

merged 16 commits into from
Nov 26, 2018

Conversation

balloob
Copy link
Member

@balloob balloob commented Nov 24, 2018

Description:

This adds foundation for cloud-extension of webhooks. Allow managing via frontend. Handling incoming webhooks from relayer will be done in another PR.

WIP because I am not done yet with adding tests.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@balloob balloob changed the title WIP: Allow managing cloud webhook Allow managing cloud webhook Nov 25, 2018
@balloob balloob merged commit 7848381 into dev Nov 26, 2018
@ghost ghost removed the in progress label Nov 26, 2018
@balloob balloob deleted the cloud-webhooks branch November 26, 2018 13:10
@balloob balloob mentioned this pull request Dec 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants