Use proper signals #18613
Merged
Use proper signals #18613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
homeassistant
added
cla-signed
integration: emulated_hue
integration: http
core
small-pr
ghost
assigned 
balloob
force-pushed
the
use-proper-signals
branch
from
d612580 to
a6dd0fc
Compare
Co-Authored-By: balloob <[email protected]>
|
For the IP ban, the proper solution would be for it to be migrated to the storage helper. |
|
I also realized that auth being a middleware means it's also being run for static resource requests 🤷♂️ I guess in a perfect world NGINX would sit in front of the static endpoint and serve that. |
balloob
added a commit
that referenced
this pull request
Nov 29, 2018
* Emulated Hue not use deprecated handler * Remove no longer needed workaround * Add middleware directly * Dont always load the ban config file * Update homeassistant/components/http/ban.py Co-Authored-By: balloob <[email protected]> * Update __init__.py
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
We finally were using the aiohttp signals correctly since 3.4.4, we can move the work around now.
We were also using a deprecated way of running a HTTP server in emulated Hue.
Checklist:
tox. Your PR cannot be merged unless tests passIf the code does not interact with devices: