Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for directv platform #18590

Merged
merged 20 commits into from
Dec 1, 2018
Merged

Add tests for directv platform #18590

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
b8f94d8
Create test for platform
ehendrix23 Nov 20, 2018
a838e5c
Multiple improvements
ehendrix23 Nov 20, 2018
4028a2f
Updates based on Martin's review
ehendrix23 Nov 20, 2018
ec23ded
Updated test based on PR#18474
ehendrix23 Nov 20, 2018
555c210
Lint issues
ehendrix23 Nov 20, 2018
ed3f7a4
Further updates based on feedback
ehendrix23 Nov 20, 2018
4a16d9f
Using async_load_platform for discovery test
ehendrix23 Nov 21, 2018
923f32a
Used HASS event_loop to setup component
ehendrix23 Nov 21, 2018
e4a2647
Updated to use state machine for # entities
ehendrix23 Nov 21, 2018
32e1115
Use hass.loop instead of getting current loop
ehendrix23 Nov 21, 2018
babfdaa
Forgot to remove asyncio
ehendrix23 Nov 21, 2018
63f9d86
Added fixtures
ehendrix23 Nov 21, 2018
897fecb
Remove not needed updates and assertions
MartinHjelmare Nov 21, 2018
0ac79bd
Return mocked dtv instance from side_effect
MartinHjelmare Nov 21, 2018
5e82118
Fix return correct fixture instance
MartinHjelmare Nov 21, 2018
4d10f26
Clean up assertions
MartinHjelmare Nov 21, 2018
c93858a
Fix remaining patches
MartinHjelmare Nov 21, 2018
3fc84b0
Mock time when setting up component in fixture
MartinHjelmare Nov 21, 2018
beb92a6
Patch time correctly
MartinHjelmare Nov 21, 2018
532ea5f
Attribute _last_update should return utcnow
MartinHjelmare Nov 21, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions homeassistant/components/media_player/directv.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,8 +162,8 @@ def update(self):
self._current['offset']
self._assumed_state = self._is_recorded
self._last_position = self._current['offset']
self._last_update = dt_util.now() if not self._paused or\
self._last_update is None else self._last_update
self._last_update = dt_util.utcnow() if not self._paused \
or self._last_update is None else self._last_update
else:
self._available = False
except requests.RequestException as ex:
Expand Down
13 changes: 10 additions & 3 deletions tests/components/media_player/common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,9 @@
from homeassistant.const import (
ATTR_ENTITY_ID, SERVICE_MEDIA_NEXT_TRACK, SERVICE_MEDIA_PAUSE,
SERVICE_MEDIA_PLAY, SERVICE_MEDIA_PLAY_PAUSE, SERVICE_MEDIA_PREVIOUS_TRACK,
SERVICE_MEDIA_SEEK, SERVICE_TOGGLE, SERVICE_TURN_OFF, SERVICE_TURN_ON,
SERVICE_VOLUME_DOWN, SERVICE_VOLUME_MUTE, SERVICE_VOLUME_SET,
SERVICE_VOLUME_UP)
SERVICE_MEDIA_SEEK, SERVICE_MEDIA_STOP, SERVICE_TOGGLE, SERVICE_TURN_OFF,
SERVICE_TURN_ON, SERVICE_VOLUME_DOWN, SERVICE_VOLUME_MUTE,
SERVICE_VOLUME_SET, SERVICE_VOLUME_UP)
from homeassistant.loader import bind_hass


Expand Down Expand Up @@ -95,6 +95,13 @@ def media_pause(hass, entity_id=None):
hass.services.call(DOMAIN, SERVICE_MEDIA_PAUSE, data)


@bind_hass
def media_stop(hass, entity_id=None):
"""Send the media player the command for stop."""
data = {ATTR_ENTITY_ID: entity_id} if entity_id else {}
hass.services.call(DOMAIN, SERVICE_MEDIA_STOP, data)


@bind_hass
def media_next_track(hass, entity_id=None):
"""Send the media player the command for next track."""
Expand Down
Loading