Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update librouteros and re-connect to api if connection is lost #18421

Merged
merged 12 commits into from
Nov 27, 2018
Merged

Update librouteros and re-connect to api if connection is lost #18421

merged 12 commits into from
Nov 27, 2018

Conversation

slackr31337
Copy link
Contributor

@slackr31337 slackr31337 commented Nov 13, 2018 •
edited
Loading

Description:

Bump librouteros version to 2.2.0 and add exception to re-connect if API connection has been lost to the Mikrotik device

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable ([example][ex-requir]).
  • New dependencies are only imported inside functions that use them ([example][ex-import]).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@homeassistant
Copy link
Contributor

Hi @slackr31337,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@ghost ghost added the in progress label Nov 13, 2018
@slackr31337 slackr31337 changed the title Master Update librouteros and re-connect to api if connection is lost Nov 13, 2018
@balloob
Copy link
Member

balloob commented Nov 27, 2018

Looks good ! Thanks

@balloob balloob merged commit c1ed2f1 into home-assistant:dev Nov 27, 2018
@ghost ghost removed the in progress label Nov 27, 2018
@balloob balloob mentioned this pull request Dec 12, 2018
Merged
@heytensai heytensai mentioned this pull request Dec 14, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@houndci-bot houndci-bot houndci-bot left review comments

@balloob balloob balloob approved these changes

Assignees
No one assigned
Labels
cla-signed core integration: device_tracker small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@slackr31337 @homeassistant @balloob @houndci-bot