Replace token in camera.push with webhook #18380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
2 tasks
dgomes
force-pushed
the
camera_push.webhook
branch
from
e4203d5 to
98e13dc
Compare
fabaff
changed the title
balloob
reviewed
Nov 27, 2018
| _LOGGER = logging.getLogger(__name__) | ||
|
|
||
| DEPENDENCIES = ['http'] | ||
| RECEIVED_DATA = 'push_camera_received' |
balloob
reviewed
Nov 27, 2018
| hass.http.register_view(CameraPushReceiver(hass, | ||
| config[CONF_IMAGE_FIELD])) | ||
| try: | ||
| hass.components.webhook.async_register(DOMAIN, 'push', |
balloob
reviewed
Nov 27, 2018
| camera.image_field) | ||
| return | ||
|
|
||
| await camera.update_image(data[camera.image_field].file.read(), |
There was a problem hiding this comment.
it's memory, it's not from the filesystem. file is the property that contains the image bytes received by the webhook.
balloob
reviewed
Nov 27, 2018
| @@ -117,6 +107,15 @@ def __init__(self, hass, name, buffer_size, timeout, image_field, | |||
| """Call when entity is added to hass.""" | |||
| self.hass.data[PUSH_CAMERA_DATA][self.webhook_id] = self | |||
|
|
|||
| try: | |||
| self.hass.components.webhook.async_register(DOMAIN, | |||
| self.entity_id, | |||
There was a problem hiding this comment.
Why entity id ? This will be shown in the UI, let's do name?
There was a problem hiding this comment.
sorry, you suggested entity name, I read entity id :(
balloob
approved these changes
Nov 27, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This moves from the temporary webhook solution to the webhook solution in #16817
Related issue (if applicable): fixes #16817
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#7451
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
REQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.If the code does not interact with devices: