Reconfigure MQTT climate component if discovery info is changed #18174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
emontnemery
changed the title
emontnemery
force-pushed
the
mqtt_discovery_update_climate
branch
from
f306a44 to
c94c936
Compare
emontnemery
force-pushed
the
mqtt_discovery_update_climate
branch
from
c94c936 to
831729d
Compare
emontnemery
changed the title
|
@OttoWinter, @balloob You reviewed #18169, do you think this one is OK too? |
balloob
reviewed
Nov 24, 2018
| CONF_CURRENT_TEMPERATURE_TOPIC | ||
| ) | ||
| } | ||
| self._qos = config.get(CONF_QOS) |
There was a problem hiding this comment.
I sometimes wonder if we should not just store config instead of every variable if we're going to just copy the value? Wouldn't that greatly clean up the code?
There was a problem hiding this comment.
That's a good point actually!
balloob
approved these changes
Nov 24, 2018
This was referenced Nov 24, 2018
This was referenced Dec 4, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Reconfigure MQTT climate component if discovery info is changed.
This PR is an extension of #18169 which introduced support for reconfiguring MQTT binary sensors.
(This is bullet 2 in home-assistant/architecture#70)
PRs for other platforms will be opened separately.
Checklist:
tox.