Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reconfigure MQTT alarm component if discovery info is changed #18173

Merged
merged 1 commit into from
Nov 24, 2018
Merged

Reconfigure MQTT alarm component if discovery info is changed #18173

merged 1 commit into from
Nov 24, 2018

Conversation

emontnemery
Copy link
Contributor

@emontnemery emontnemery commented Nov 4, 2018 •
edited
Loading

Description:

Reconfigure MQTT alarm component if discovery info is changed.
This PR is an extension of #18169 which introduced support for reconfiguring MQTT binary sensors.

(This is bullet 2 in home-assistant/architecture#70)

PRs for other platforms will be opened separately.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox.
  • Tests have been added to verify that the new code works.

@emontnemery emontnemery requested a review from a team as a code owner November 4, 2018 00:07
@ghost ghost added the in progress label Nov 4, 2018
@fabaff
Copy link
Member

fabaff commented Nov 4, 2018

This PR contains commits from #18169.

@emontnemery emontnemery changed the title Recreate alarm component if discovery info is changed WIP - Recreate alarm component if discovery info is changed Nov 4, 2018
@emontnemery emontnemery force-pushed the mqtt_discovery_update_alarm branch from 7a3bcca to 71fcc95 Compare November 20, 2018 18:50
@ghost ghost assigned emontnemery Nov 20, 2018
@emontnemery emontnemery changed the title WIP - Recreate alarm component if discovery info is changed Reconfigure MQTT alarm component if discovery info is changed Nov 20, 2018
@emontnemery
Copy link
Contributor Author

@fabaff #18169 is merged to dev now and this PR has been rebased and refactored in line with #18169

@emontnemery
Copy link
Contributor Author

@OttoWinter, @balloob You reviewed #18169, do you think this one is OK too?

@balloob balloob merged commit 5e18d52 into home-assistant:dev Nov 24, 2018
@ghost ghost removed the in progress label Nov 24, 2018
@emontnemery emontnemery deleted the mqtt_discovery_update_alarm branch December 2, 2018 16:29
@balloob balloob mentioned this pull request Dec 12, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@balloob balloob balloob approved these changes

Assignees

@emontnemery emontnemery

Labels
cla-signed core integration: mqtt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@emontnemery @fabaff @balloob @homeassistant