Clear device state attributes if update from feed fails for geo_rss_events sensor #17249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
homeassistant
added
platform: sensor.geo_rss_events
small-pr
balloob
approved these changes
Oct 8, 2018
exxamalte
deleted the
geo-rss-events-sensors-fix-for-not-removing-state-attributes
branch
Merged
ghost
added
integration: geo_rss_events
and removed
platform: sensor.geo_rss_events
labels
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
In the case where a feed becomes unavailable, the state is set to
0(same as before the refactoring in version 0.80), but the device state attributes are not cleared.This change will fix this and clear the device state attributes if the update from the external feed fails. A test case has been amended to test this behaviour.
Related issue (if applicable): n/a
Pull request in home-assistant.io with documentation (if applicable): n/a
Example entry for
configuration.yaml(if applicable): n/aChecklist:
tox. Your PR cannot be merged unless tests passIf the code does not interact with devices: