Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated georss_client to 0.3 #17239

Conversation

exxamalte
Copy link
Contributor

@exxamalte exxamalte commented Oct 8, 2018

Description:

Updating georss_client library to version 0.3 to fix an issue where the external RSS feed contains an entry that does not contain any geo location information.
In the new version of this library an entry without geo location information is simply ignored without affecting the correct processing of any other entries in the feed.

Related issue (if applicable): fixes #17233

Pull request in home-assistant.io with documentation (if applicable): n/a

Example entry for configuration.yaml (if applicable):

sensor:
  - platform: geo_rss_events
    name: CAL FIRE Incidents
    url: http://cdfdata.fire.ca.gov/incidents/rss.xml
    radius: 100.0

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.

@awarecan awarecan added this to the 0.80 milestone Oct 8, 2018
@balloob balloob merged commit 394ffc4 into home-assistant:dev Oct 8, 2018
@ghost ghost removed the in progress label Oct 8, 2018
@exxamalte exxamalte deleted the geo-rss-events-sensor-fix-for-missing-geo-location branch October 8, 2018 12:21
balloob pushed a commit that referenced this pull request Oct 8, 2018
@balloob balloob mentioned this pull request Oct 12, 2018
@home-assistant home-assistant locked and limited conversation to collaborators Feb 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GeoRSS got error on 0.80.0b2
5 participants