Fix potential MQTT discovery race condition #17208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
homeassistant
added
cla-signed
integration: mqtt
core
small-pr
ghost
assigned 
balloob
reviewed
Oct 7, 2018
| @@ -51,6 +52,7 @@ | |||
| } | |||
|
|
|||
| ALREADY_DISCOVERED = 'mqtt_discovered_components' | |||
| CONFIG_ENTRY_LOCK = 'mqtt_config_entry_lock' | |||
There was a problem hiding this comment.
Can you prefix this with DATA_ so it's more clear what it's used for.
balloob
approved these changes
Oct 8, 2018
balloob
pushed a commit
that referenced
this pull request
Oct 8, 2018
* Fix potential MQTT discovery race condition * Rename data key
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixes #17004 (review) by introducing a global lock on all discovery config entry loading.
Checklist:
tox. Your PR cannot be merged unless tests passIf the code does not interact with devices: