-
-
Notifications
You must be signed in to change notification settings - Fork 31.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LG WebOS Play Youtube URL using Launch App Params #13588
Closed
Closed
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
dfe80a9
LG WebOS Play Youtube URL using Launch App Params
cyberluke 4bb11a1
Allow launch Youtube App with startup params of video id.
cyberluke d436874
LG WebOS Play Youtube URL using Launch App Params
cyberluke 26f29f9
LG WebOS Play Youtube URL using Launch App Params
cyberluke File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should not do this. Just add support for a
media_type
with valueyoutube
and have the user pass in the video ID asmedia_id
. Remove all the YouTube url parsing from this PR, that does not belong in Home Assistant.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, what does mean "Just add support for a media_type". Which class or file? Is it then the correct place to put Youtube parsing urls here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this function. Just check
if media_type == "youtube"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should remove all YouTube url parsing. The user will need to pass in the ID themselves
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No no no no, I have to stand against this. The correct approach would be to create new class "MediaTypes.Youtube" or something like that and insert the parsing here. The parsing is required. I did not know where to put it, so I put it here. Why? Because it is tied for this particular case, but it is true that it might be valuable also for someone else. Why is it required? Because you see only part of code. This was my first pull request just to try how it works here. It is required in order to give voice commands to TV like "Play {event or artist or video name} on Youtube" intent. Then it will correctly search Youtube and return the id. You don't want to let user tell a voice command: "Play youtube id" and then spell hex encoded characters lol.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You know if you would help right away, we both save some time. Now it's your turn to show you are not what I think you are :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@balloob where to put youtube code, so I can maybe put it in 2nd pull request, please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Already answered this. #13588 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But that's the problem: "You have to add Youtube parsing to your own intent handler.". What if this functionality is required by some other components? How to make it user friendly, so other people can use it like a directive or something? Do you have some example? Also your default intent handlers are a mess. A lot of users here and on forums complaining it does not even support TTS. I did a lot of work on this subject, added also optional TTS configuration if u don't want to use Alexa. Then I added also multilanguage support, so you can speak in your native language, then u get answer in your native language. It just supports your natural language out of the box together with english. I just add simple pull request to try out the process, but I feel you are really arrogant & don't care bro.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you have specific requirements for Youtube functionality to be used globally or together with LG package, please provide some example than 1 simple answer not telling anything and not providing solution to my problem. It will also save us time for pull requests, so I do it how you want. If you would provide this information a month ago in simple and professional manner, we would not have to do this exhausting conversation.