-
-
Notifications
You must be signed in to change notification settings - Fork 32.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Sonos device attribute with grouping information #13553
Conversation
198bcbd
to
1503ad1
Compare
I think we should implement the group/snapshot feature on core to generalize the handling |
Okay ... and what do you think about this PR? 😃 |
So I'm fine with storing this in the state machine. I am a bit confused as to why we would make it more difficult to find who is the coordinator? Isn't it that we can only send commands to the coordinator? |
Sending commands to slaves works without this, the platform will redirect the command to the coordinator. The attribute in this PR was hashed out in this forum thread after the original solution with I think it is okay to be a bit verbose because it is not used much. |
…13553) Moves RainMachine to component/hub model Updated requirements Updated coverage Hound violations
Description:
This PR replaces the Sonos
is_coordinator
boolean attribute with a more useful attributesonos_group
that reveals the actual speaker group arrangement.Related issue (if applicable): suggested in forum
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#<home-assistant.github.io PR number goes here>
BREAKING CHANGE NOTE: The
media_player.sonos
attributeis_coordinator
has been removed; the new attributesonos_group
(listing all group members, coordinator first) can be used instead.Example template:
This will list the players that used to have
is_coordinator == True
:Checklist:
tox
.If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
New dependencies have been added to theREQUIREMENTS
variable (example).New dependencies are only imported inside functions that use them (example).New dependencies have been added torequirements_all.txt
by runningscript/gen_requirements_all.py
.New files were added to.coveragerc
.