Fix Twinkly raise on progress #133601
Merged
Fix Twinkly raise on progress #133601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
home-assistant
bot
added
bugfix
cla-signed
integration: twinkly
small-pr
|
Hey there @dr1rrb, @RobBie1221, @Olen, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
|
Isn't the main problem here that the integration believes it is the same device that is being set up twice? |
|
Yes, @zweckj actually caught me on that so I removed the link to the issue |
bdraco
approved these changes
Dec 19, 2024
bdraco
reviewed
Dec 19, 2024
| @@ -45,7 +45,9 @@ async def async_step_user( | |||
| except (TimeoutError, ClientError): | |||
| errors[CONF_HOST] = "cannot_connect" | |||
| else: | |||
| await self.async_set_unique_id(device_info[DEV_ID]) | |||
| await self.async_set_unique_id( | |||
| device_info[DEV_ID], raise_on_progress=False | |||
There was a problem hiding this comment.
Probably could use a test for a competing discovery
|
Oh lol, looking at the diagnostics, both lihgts have the same UUID |
|
Any reason we pick the uuid over the mac address for the unique id? |
bdraco
approved these changes
Dec 19, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Fix Twinkly raise on progress
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: