Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump pycups to 2.0.4 #132514

Merged
merged 1 commit into from
Dec 6, 2024
Merged

Bump pycups to 2.0.4 #132514

merged 1 commit into from
Dec 6, 2024

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Dec 6, 2024

Proposed change

pycups 1.9.73 does not work on Python 3.13 because it calls PyEval_CallObject which no longer exists. 2.0.3 changed the call to PyObject_Call

changelog: OpenPrinting/pycups@1.9.73...v2.0.4

https://docs.python.org/3/whatsnew/3.13.html

ImportError: Error relocating /usr/local/lib/python3.13/site-packages/cups.cpython-313-x86_64-linux-musl.so: PyEval_CallObject: symbol not found

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

pycups 1.9.73 does not work on Python 3.13 because
it calls `PyEval_CallObject` which no longer exists.
2.0.3 changed the call to `PyObject_Call`

https://docs.python.org/3/whatsnew/3.13.html

ImportError: Error relocating /usr/local/lib/python3.13/site-packages/cups.cpython-313-x86_64-linux-musl.so: PyEval_CallObject: symbol not found
@bdraco bdraco added this to the 2024.12.2 milestone Dec 6, 2024
@home-assistant
Copy link

home-assistant bot commented Dec 6, 2024

Hey there @fabaff, mind taking a look at this pull request as it has been labeled with an integration (cups) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of cups can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign cups Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@bdraco
Copy link
Member Author

bdraco commented Dec 6, 2024

I don't have a good test case for this but its likely better than completely broken

@bdraco bdraco marked this pull request as ready for review December 6, 2024 21:01
@bdraco bdraco requested a review from fabaff as a code owner December 6, 2024 21:01
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @bdraco 👍

../Frenck

@frenck frenck merged commit 5bae000 into dev Dec 6, 2024
65 checks passed
@frenck frenck deleted the bump_cups branch December 6, 2024 21:05
vche pushed a commit to vche/hass-core that referenced this pull request Dec 7, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Dec 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants