Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump propcache to 0.2.1 #132022

Merged
merged 2 commits into from
Dec 1, 2024
Merged

Bump propcache to 0.2.1 #132022

merged 2 commits into from
Dec 1, 2024

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Dec 1, 2024

Proposed change

changelog: aio-libs/propcache@v0.2.0...v0.2.1

There is a fix to ensure wheels get built with a compatible Cython version which would only affect core installs that are building their own wheel locally

We were missing wheels for armv6l w/Python 3.13 https://wheels.home-assistant.io/musllinux/ because skip-binary was not set on the core wheels build for propcache

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

changelog: aio-libs/propcache@v0.2.0...v0.2.1

There is a fix to ensure wheels get built with a compatible
Cython version which would only affect core installs that
are building their own wheel locally
@bdraco bdraco added this to the 2024.12.0 milestone Dec 1, 2024
@home-assistant home-assistant bot added cla-signed core dependency small-pr PRs with less than 30 lines. labels Dec 1, 2024
@@ -143,7 +143,7 @@ jobs:
wheels-key: ${{ secrets.WHEELS_KEY }}
env-file: true
apk: "libffi-dev;openssl-dev;yaml-dev;nasm;zlib-dev"
skip-binary: aiohttp;multidict;yarl;SQLAlchemy
skip-binary: aiohttp;multidict;propcache;yarl;SQLAlchemy
Copy link
Member Author

@bdraco bdraco Dec 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We were missing wheels for armv6l w/Python 3.13 https://wheels.home-assistant.io/musllinux/

@bdraco bdraco marked this pull request as ready for review December 1, 2024 18:59
@bdraco bdraco requested a review from a team as a code owner December 1, 2024 18:59
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @bdraco 👍

../Frenck

@frenck frenck merged commit 82e190d into dev Dec 1, 2024
85 of 86 checks passed
@frenck frenck deleted the propcache_021 branch December 1, 2024 20:37
@bdraco
Copy link
Member Author

bdraco commented Dec 1, 2024

Thanks

frenck pushed a commit that referenced this pull request Dec 2, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Dec 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants