Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce precision loss when converting HomeKit temperature #131973

Merged
merged 2 commits into from
Nov 30, 2024

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Nov 30, 2024

Proposed change

The utility did rounding, but pyhap can do a better job of this because it knows the step sizes. Remove the rounding in the util and let pyhap handle rounding the values based on the step size. While its impossible to fix every issue with loss of precision but we can at least make it a bit better.

fixes #98578

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

The utility did rounding, but pyhap can do a better job
of this because it knows the step sizes. Remove the rounding
in the util and let pyhap handle rounding the values based
on the step size

fixes #98578
@bdraco bdraco marked this pull request as ready for review November 30, 2024 21:00
@bdraco
Copy link
Member Author

bdraco commented Nov 30, 2024

Thanks

@bdraco bdraco merged commit a0d5fda into dev Nov 30, 2024
34 checks passed
@bdraco bdraco deleted the reduce_precision_loss_hk_temps branch November 30, 2024 22:09
zweckj pushed a commit to zweckj/home-assistant-core that referenced this pull request Dec 1, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Dec 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Thermostat rounding errors - changing setpoint
3 participants