Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add go2rtc workaround for HA managed one until upstream fixes it #130139

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

edenhaus
Copy link
Contributor

@edenhaus edenhaus commented Nov 8, 2024

Breaking change

Proposed change

Currently, there exists a go2rtc endless loop with the config we use it.
The problem is the following line: f"ffmpeg:{camera.entity_id}#audio=opus". By specifying the go2rtc name, go2rtc calls the ffmpeg in an endless loop as it is using itself as a source for the stream, which, of course, will not work.
Until the problem is fixed upstream, I have added with this PR a workaround for the go2rtc instance managed by HA.

It's not possible to add this workaround for self-hosted instances, as we would need to know the port where the internal RTSP server is running. This is not straightforward, as the port can be changed with the config. Getting the config and parsing it is out of the scope of this bug fix.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented Nov 8, 2024

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (go2rtc) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of go2rtc can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign go2rtc Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@edenhaus edenhaus added the bugfix label Nov 8, 2024
@edenhaus edenhaus added this to the 2024.11.1 milestone Nov 8, 2024
@edenhaus edenhaus marked this pull request as ready for review November 8, 2024 14:22
@edenhaus edenhaus requested a review from a team as a code owner November 8, 2024 14:22
@edenhaus edenhaus merged commit 51e691f into dev Nov 8, 2024
32 checks passed
@edenhaus edenhaus deleted the edenhaus-go2rtc-no-audio-workaround branch November 8, 2024 14:54
@carloda
Copy link

carloda commented Nov 9, 2024

@edenhaus edenhaus Hi, are you saying it could be related to this problem? #130202

@frenck
Copy link
Member

frenck commented Nov 9, 2024

@carloda This is a PR; if you want to discuss or report an issue, the issue you linked is a more appropriate place.

Please note that pinging people might come across as demanding attention; while you probably mean well, we do discourage it.

Thanks for understanding 👍

../Frenck

@carloda
Copy link

carloda commented Nov 9, 2024

@carloda This is a PR; if you want to discuss or report an issue, the issue you linked is a more appropriate place.

Please note that pinging people might come across as demanding attention; while you probably mean well, we do discourage it.

Thanks for understanding 👍

../Frenck

I apologize, my intention was to bring to light an issue and if it was related to the discussion to close it, I apologize again. :/

@frenck
Copy link
Member

frenck commented Nov 9, 2024

No worries 👍

@github-actions github-actions bot locked and limited conversation to collaborators Nov 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants