-
-
Notifications
You must be signed in to change notification settings - Fork 30.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use RTCIceCandidate instead of str for candidate #129793
Conversation
Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
|
||
def as_dict(self) -> dict[str, Any]: | ||
"""Return a dict representation of the message.""" | ||
return { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This method will removed in a follow-up, where also the frontend will migrate to RTCIceCandidate
Breaking change
Changing the type of the
candidate
fromstr
toRTCIceCandidate
on:Camera
-> methodasync_on_webrtc_candidate
CameraWebRTCProvider
-> methodasync_on_webrtc_candidate
WebRTCCandidate
Proposed change
Changing the type of the
candidate
fromstr
toRTCIceCandidate
on:Camera
-> methodasync_on_webrtc_candidate
CameraWebRTCProvider
-> methodasync_on_webrtc_candidate
WebRTCCandidate
It was discussed internally that this PR should be cherry-picked into the beta to avoid a breaking change in the future, as the changed methods are not part of any stable release yet.
Frontend and WS changes will be in a follow-up PR, as they don't need to be cherry-picked.
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: