Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase Z-Wave fallback thermostat range to 0-50 C #128543

Merged
merged 2 commits into from
Oct 17, 2024

Conversation

MindFreeze
Copy link
Contributor

Proposed change

Related to home-assistant/architecture#1152
The current 7-35 C is reported to be too restricted for some users so we increase it to 0-50 for now

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @home-assistant/z-wave, mind taking a look at this pull request as it has been labeled with an integration (zwave_js) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of zwave_js can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign zwave_js Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@MindFreeze MindFreeze marked this pull request as ready for review October 17, 2024 06:26
@MindFreeze MindFreeze requested a review from a team as a code owner October 17, 2024 06:26
@MartinHjelmare MartinHjelmare changed the title Z-Wave JS: Increase fallback thermostat range to 0-50 C Increase Z-Wave fallback thermostat range to 0-50 C Oct 17, 2024
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the failing test.

@home-assistant home-assistant bot marked this pull request as draft October 17, 2024 06:48
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@MindFreeze MindFreeze marked this pull request as ready for review October 17, 2024 07:09
@AlCalzone
Copy link
Contributor

AlCalzone commented Oct 17, 2024

Let me double check if we can handle the certification requirements with this change.

Edit: We currently can.

That's not a guarantee that it will stay that way though, since they might add a new test that we're able to set a freezer's thermostat without known limits to -18° or whatever.

@@ -421,7 +419,7 @@ def extra_state_attributes(self) -> dict[str, str] | None:
@property
def min_temp(self) -> float:
"""Return the minimum temperature."""
min_temp = DEFAULT_MIN_TEMP
min_temp = 0.0 # Not using DEFAULT_MIN_TEMP to allow wider range
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe make it -50 to support freezers?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was just speaking hypothetically. Not sure if that will ever be an issue, and if it is, we could fix it then. Because right now, 0° seems more reasonable for those users with V1 thermostats.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok.

Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MartinHjelmare MartinHjelmare merged commit 8533f85 into home-assistant:dev Oct 17, 2024
32 checks passed
@MartinHjelmare MartinHjelmare added this to the 2024.10.3 milestone Oct 17, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Oct 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants