-
-
Notifications
You must be signed in to change notification settings - Fork 31.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase Z-Wave fallback thermostat range to 0-50 C #128543
Increase Z-Wave fallback thermostat range to 0-50 C #128543
Conversation
Hey there @home-assistant/z-wave, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the failing test.
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Let me double check if we can handle the certification requirements with this change. Edit: We currently can. That's not a guarantee that it will stay that way though, since they might add a new test that we're able to set a freezer's thermostat without known limits to -18° or whatever. |
@@ -421,7 +419,7 @@ def extra_state_attributes(self) -> dict[str, str] | None: | |||
@property | |||
def min_temp(self) -> float: | |||
"""Return the minimum temperature.""" | |||
min_temp = DEFAULT_MIN_TEMP | |||
min_temp = 0.0 # Not using DEFAULT_MIN_TEMP to allow wider range |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe make it -50
to support freezers?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was just speaking hypothetically. Not sure if that will ever be an issue, and if it is, we could fix it then. Because right now, 0° seems more reasonable for those users with V1 thermostats.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Proposed change
Related to home-assistant/architecture#1152
The current 7-35 C is reported to be too restricted for some users so we increase it to 0-50 for now
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: