Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix playing media via roku #128133

Merged
merged 7 commits into from
Oct 13, 2024
Merged

Fix playing media via roku #128133

merged 7 commits into from
Oct 13, 2024

Conversation

ctalkington
Copy link
Contributor

@ctalkington ctalkington commented Oct 11, 2024

Proposed change

This works around a long standing issue of Roku locking down the Play on Roku app.

There is atleast one app now published Media Assistant that supports the same parameters. Alternatively, users can install development versions and use "dev" as the app id.

We default to the old Play on Roku app for backcompat with older devices that aren't on Roku 11.5

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@ctalkington ctalkington changed the title re-support playing media via roku fix playing media via roku Oct 11, 2024
@ctalkington ctalkington marked this pull request as ready for review October 12, 2024 19:15
@ctalkington ctalkington added this to the 2024.10.3 milestone Oct 12, 2024
@joostlek joostlek changed the title fix playing media via roku Fix playing media via roku Oct 13, 2024
@ctalkington ctalkington merged commit cb1e5a2 into dev Oct 13, 2024
31 checks passed
@ctalkington ctalkington deleted the ctalkington-roku-media branch October 13, 2024 17:41
@github-actions github-actions bot locked and limited conversation to collaborators Oct 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Roku Media player does not stream to "Play On Roku"
3 participants