Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add basic testing framework to LG ThinQ #127785

Merged
merged 16 commits into from
Nov 4, 2024
Merged

Add basic testing framework to LG ThinQ #127785

merged 16 commits into from
Nov 4, 2024

Conversation

joostlek
Copy link
Member

@joostlek joostlek commented Oct 7, 2024

Proposed change

Add basic testing framework to LG ThinQ

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

  • Add number platform to LG ThinQ integration

  • Add number platform to LG ThinQ integration

  • Update for shebangs

  • Modify update_status

Co-authored-by: jangwon.lee [email protected]

@LG-ThinQ-Integration @JangwonLeeLG
Add number platform to LG ThinQ integration (home-assistant#125711)
0177313 
* Add number platform to LG ThinQ integration

* Add number platform to LG ThinQ integration

* Update for shebangs

* Modify update_status

---------

Co-authored-by: jangwon.lee <[email protected]>
@LG-ThinQ-Integration @JangwonLeeLG @joostlek
Add event platform to LG ThinQ integration (home-assistant#125800)
527cd36 
* Add event platform to LG ThinQ integration

* Add error and notification translations

* Update event.py

* Fix translations

* Fix

---------

Co-authored-by: jangwon.lee <[email protected]>
Co-authored-by: Joostlek <[email protected]>
@LG-ThinQ-Integration @JangwonLeeLG
Add mqtt to LG ThinQ integration (home-assistant#125869)
cd7ac53 
* Add mqtt to LG ThinQ integration

* Change file mode

* Update for reviews

* Change ways to access coordinators in runtime_data

---------

Co-authored-by: jangwon.lee <[email protected]>
@LG-ThinQ-Integration @JangwonLeeLG
Add fan platform to LG ThinQ integration (home-assistant#126712)
f09e431 
* Add fan platform to LG ThinQ integration

* Turn off on 0 percentage

---------

Co-authored-by: jangwon.lee <[email protected]>
@LG-ThinQ-Integration @JangwonLeeLG
Bump thinqconnnect to 0.9.8 (home-assistant#126710)
b1cf70d 
Co-authored-by: jangwon.lee <[email protected]>
@LG-ThinQ-Integration @JangwonLeeLG
@YunseonPark-LGE @joostlek
Add vacuum platform to LG ThinQ integration (home-assistant#126711)
3fbc4c4 
* Add vacuum to LG ThinQ integration

* Update vacuum.py

remove constructor

* restore constructor

* Fix pylint, mypy issues

* Update for reviews

* Remove constructor

---------

Co-authored-by: jangwon.lee <[email protected]>
Co-authored-by: YunseonPark-LGE <[email protected]>
Co-authored-by: Joostlek <[email protected]>
@LG-ThinQ-Integration @JangwonLeeLG @joostlek
Add sensor platform to LG ThinQ integration (home-assistant#125231)
bc71673 
* Add sensor platform to LG ThinQ integration

* Dedup

* Dedup

* Dedup

* Dedup

* Dedup

* Fix water type enum

* Dedup

---------

Co-authored-by: jangwon.lee <[email protected]>
Co-authored-by: Joostlek <[email protected]>
@joostlek
Add basic testing framework to LG ThinQ
2da7fda
@LG-ThinQ-Integration @JangwonLeeLG
Add climate platform to LG ThinQ integration (home-assistant#126241)
6992661 
* Add climate platform to LG ThinQ integration

* Update for reviews

* Modify update_status

---------

Co-authored-by: jangwon.lee <[email protected]>
@joostlek
Merge branch 'lg_thinq' into lg_thinq_tests
b0f6c08
@joostlek
Add basic testing framework to LG ThinQ
cfb69e8
@joostlek
Add basic testing framework to LG ThinQ
321a92b
@joostlek
Add testing framework for LG ThinQ (home-assistant#127237)
62ecd50 
* Add basic testing framework to LG ThinQ

* Add basic testing framework to LG ThinQ

* Add basic testing framework to LG ThinQ
@frenck
Revert "Add testing framework for LG ThinQ" (home-assistant#127779)
a8974cc 
Revert "Add testing framework for LG ThinQ (home-assistant#127237)"

This reverts commit 62ecd50.
@joostlek
Merge branch 'lg_thinq' into lg_thinq_tests
b0765b6
@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Oct 18, 2024
@joostlek joostlek changed the base branch from lg_thinq to dev October 28, 2024 16:23
@joostlek
Merge branch 'dev' into lg_thinq_tests
63d01a0 
# Conflicts:
#	homeassistant/components/lg_thinq/__init__.py
#	homeassistant/components/lg_thinq/event.py
#	homeassistant/components/lg_thinq/icons.json
#	homeassistant/components/lg_thinq/mqtt.py
#	homeassistant/components/lg_thinq/sensor.py
#	homeassistant/components/lg_thinq/strings.json
@joostlek joostlek mentioned this pull request Oct 30, 2024
Merged
19 tasks
frenck
frenck approved these changes Nov 4, 2024
View reviewed changes
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @joostlek 👍

../Frenck

@frenck frenck merged commit 22f8f11 into home-assistant:dev Nov 4, 2024
28 checks passed
@joostlek joostlek deleted the lg_thinq_tests branch November 4, 2024 19:04
@cdce8p cdce8p mentioned this pull request Nov 4, 2024
Merged
19 tasks
@joostlek joostlek added this to the 2024.11.0 milestone Nov 5, 2024
frenck added a commit that referenced this pull request Nov 5, 2024
@joostlek @JangwonLeeLG
@YunseonPark-LGE @LG-ThinQ-Integration @frenck
Add basic testing framework to LG ThinQ (#127785)
00ea1ca 
Co-authored-by: jangwon.lee <[email protected]>
Co-authored-by: Joostlek <[email protected]>
Co-authored-by: YunseonPark-LGE <[email protected]>
Co-authored-by: LG-ThinQ-Integration <[email protected]>
Co-authored-by: Franck Nijhof <[email protected]>
@github-actions github-actions bot locked and limited conversation to collaborators Nov 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@frenck frenck frenck approved these changes

Assignees
No one assigned
Labels
cherry-picked cla-signed Hacktoberfest has-tests integration: lg_thinq new-feature small-pr PRs with less than 30 lines. smash Indicator this PR is close to finish for merging or closing
Projects
None yet
Milestone
2024.11.0
Development

Successfully merging this pull request may close these issues.
3 participants
@joostlek @frenck @LG-ThinQ-Integration