Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump yarl to 1.13.0 #126872

Merged
merged 2 commits into from
Sep 27, 2024
Merged

Bump yarl to 1.13.0 #126872

merged 2 commits into from
Sep 27, 2024

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Sep 27, 2024

Proposed change

changelog: aio-libs/yarl@v1.12.1...v1.13.0

Additional validation and IPv6 fixes

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@bdraco bdraco requested a review from a team as a code owner September 27, 2024 01:25
@home-assistant home-assistant bot added cla-signed core dependency small-pr PRs with less than 30 lines. labels Sep 27, 2024
@bdraco bdraco added this to the 2024.10.0 milestone Sep 27, 2024
@bdraco bdraco marked this pull request as draft September 27, 2024 02:31
@bdraco
Copy link
Member Author

bdraco commented Sep 27, 2024

It looks like our mocks are incorrectly leaking the port into the host field and the new yarl is catching the error

Turned out to be a bug in aiohttp. Solved via #126882 and will be solved in a future aiohttp via aio-libs/aiohttp#9309

@bdraco bdraco marked this pull request as ready for review September 27, 2024 09:05
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @bdraco 👍

../Frenck

@frenck frenck merged commit 40e83dd into dev Sep 27, 2024
44 checks passed
@frenck frenck deleted the yarl_13 branch September 27, 2024 09:35
frenck pushed a commit that referenced this pull request Sep 27, 2024
zxdavb pushed a commit to zxdavb/hass that referenced this pull request Sep 27, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Sep 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants