Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump sfrbox-api to 0.0.10 #125405

Merged
merged 3 commits into from
Sep 6, 2024
Merged

Bump sfrbox-api to 0.0.10 #125405

merged 3 commits into from
Sep 6, 2024

Conversation

AlexT59
Copy link
Contributor

@AlexT59 AlexT59 commented Sep 6, 2024

Proposed change

Release details:

Full compare: hacf-fr/sfrbox-api@v0.0.8...v0.0.10

In particular, see:

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

cc @epenet

Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @AlexT59

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant home-assistant bot marked this pull request as draft September 6, 2024 10:51
@home-assistant
Copy link

home-assistant bot commented Sep 6, 2024

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@epenet epenet changed the title bump sfr_box to 0.0.10 Bump sfrbox-api to 0.0.10 Sep 6, 2024
@epenet epenet added this to the 2024.9.1 milestone Sep 6, 2024
@AlexT59 AlexT59 marked this pull request as ready for review September 6, 2024 10:54
@epenet
Copy link
Contributor

epenet commented Sep 6, 2024

Please also update the manifest file

"requirements": ["sfrbox-api==0.0.8"]

@epenet epenet marked this pull request as draft September 6, 2024 10:56
@AlexT59
Copy link
Contributor Author

AlexT59 commented Sep 6, 2024

oups forget that

@AlexT59 AlexT59 marked this pull request as ready for review September 6, 2024 11:03
@AlexT59 AlexT59 requested a review from epenet as a code owner September 6, 2024 11:03
@epenet
Copy link
Contributor

epenet commented Sep 6, 2024

Since we are now returning None when the box is returning empty data, it looks like we need to make some extra adjustments to the code to satisfy mypy.

@joostlek joostlek merged commit c4cc158 into home-assistant:dev Sep 6, 2024
41 of 42 checks passed
balloob pushed a commit that referenced this pull request Sep 6, 2024
* bump sfr_box requirement to 0.0.10

* upate manifest file

* Handle None values

---------

Co-authored-by: epenet <[email protected]>
@balloob balloob mentioned this pull request Sep 6, 2024
Gigatrappeur pushed a commit to Gigatrappeur/ha-core that referenced this pull request Sep 7, 2024
* bump sfr_box requirement to 0.0.10

* upate manifest file

* Handle None values

---------

Co-authored-by: epenet <[email protected]>
@github-actions github-actions bot locked and limited conversation to collaborators Sep 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unknown error occurred - SFR Box integration
4 participants