-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Component for Sony Bravia TV with Pre-Shared Key #12464
Conversation
Would it not be possible to implement this into the current braviatv component? |
@bakedraccoon The connection towards the TV using PIN and PSK is quite different. Besides that all models after 2014 which support an external connection seem to have support for PSK. And when I used the bravia component with PIN I had a lot of issues, first with making a proper connection to the TV and once that was achieved, the connection was always lost after a few days. |
Thanks! 🐊 |
This should not have been its own platform. Instead, this should have been part of the other bravia TV integration. The API is literally the same and it seems like a lot of code has been copy pasted. I've decided to pull this integration from release 0.64. Please submit a new PR that combines PSK support into the original Bravia integration. |
Sorry for merging, should the |
Understood, I will have a look at it. |
Since it's just 2 auth methods in front of the same API, it should indeed be part of |
I have a Bravia which supports both pin and psk. Testing both is no issue for me. I had no issues with pin before I moved my ha from a Mac mini to a 12 core 1u Dell with two network interfaces. On the mini I had one with multiple virtual nics/vlans and no WOL issues. Searching around I suddenly remembered that i had the WOL issue in my homebridge setup before I moved to ha. I patched that too. |
Description:
Sony Bravia TVs of 2014 and later can be connected using a Pre-Shared Key (PSK) instead of the PIN method which is used in the current braviatv component.
Connecting with the TV using the PSK is a bit easier and also more reliable then the PIN method.
Besides that I have added some more features to this component:
When using the built-in TV tuner:
See this topic on the HA forum for more details.
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#4694
Example entry for
configuration.yaml
(if applicable):Checklist:
If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
tox
run successfully. Your PR cannot be merged unless tests passREQUIREMENTS
variable (example).requirements_all.txt
by runningscript/gen_requirements_all.py
..coveragerc
.If the code does not interact with devices:- [ ] Local tests withtox
run successfully. Your PR cannot be merged unless tests pass- [ ] Tests have been added to verify that the new code works.