Dynamically add Airzone entities #121891
Dynamically add Airzone entities #121891
Conversation
Signed-off-by: Álvaro Fernández Rojas <[email protected]>
home-assistant
bot
added
cla-signed
has-tests
integration: airzone
new-feature
small-pr
|
Why don't we dynamically add devices? |
Honestly because I don't know how to do it... |
|
I recently implemented this in Mealie todo list. Also knocki's event has this. |
This reverts commit 3ecc084.
Signed-off-by: Álvaro Fernández Rojas <[email protected]>
Signed-off-by: Álvaro Fernández Rojas <[email protected]>
Noltari
changed the title
Thanks @joostlek, |
|
I dont exactly know how much work goes into one of them, but i dont think it would be that big of a deal to put them into one |
Signed-off-by: Álvaro Fernández Rojas <[email protected]>
Signed-off-by: Álvaro Fernández Rojas <[email protected]>
Signed-off-by: Álvaro Fernández Rojas <[email protected]>
Signed-off-by: Álvaro Fernández Rojas <[email protected]>
Signed-off-by: Álvaro Fernández Rojas <[email protected]>
Noltari
changed the title
@joostlek many thanks for your help :) Let me know if it's too much for a single PR and I will split it into separate PRs. |
| async_add_entities( | ||
| AirzoneSystemBinarySensor( | ||
| coordinator, | ||
| description, | ||
| entry, | ||
| system_zone_id, | ||
| systems_data.get(system_zone_id), | ||
| ) | ||
| for system_zone_id in new_systems | ||
| for description in SYSTEM_BINARY_SENSOR_TYPES | ||
| if description.key in systems_data.get(system_zone_id) | ||
| ) | ||
| added_systems.update(new_systems) | ||
|
|
||
| zones_data = coordinator.data.get(AZD_ZONES, {}) | ||
| received_zones = set(zones_data) | ||
| new_zones = received_zones - added_zones | ||
| if new_zones: | ||
| async_add_entities( |
There was a problem hiding this comment.
Can we combine the call? Async_add_entities is quite expensive iirc
| assert state is None | ||
|
|
||
| mock_hvac.return_value = HVAC_MOCK | ||
| async_fire_time_changed(hass, utcnow() + SCAN_INTERVAL) |
There was a problem hiding this comment.
Please use the freezer as well
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Signed-off-by: Álvaro Fernández Rojas <[email protected]>
Signed-off-by: Álvaro Fernández Rojas <[email protected]>
| entry, | ||
| added_hotwater = True | ||
|
|
||
| if not added_webserver and AZD_WEBSERVER in coordinator.data: |
There was a problem hiding this comment.
Can this be added on runtime? Or is this something that is there by default?
You could also make separate listeners for these and if the webserver is already set up, we don't attach the listener
There was a problem hiding this comment.
Actually you're right, so on a second thought I've removed the webserver and water heater from the listeners since those can't be dynamically added.
Signed-off-by: Álvaro Fernández Rojas <[email protected]>
Signed-off-by: Álvaro Fernández Rojas <[email protected]>
Commit c044417 incorrecly renamed system_id to system_zone_id. Fixes: c044417 ("Dynamically add Airzone entities (home-assistant#121891)") Signed-off-by: Álvaro Fernández Rojas <[email protected]>
Proposed change
Reload Airzone config entry on new devices in order to expose new devices and entities.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: