Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump aioaquacell to 0.1.8 #121253

Merged
merged 1 commit into from
Jul 4, 2024

Conversation

Jordi1990
Copy link
Contributor

Proposed change

Bump aioaquacell to 0.1.8
This fixes an issue where certain parts of the API response could not be parsed properly and adds debug logging for the API response.
Jordi1990/aioaquacell@v0.1.7...v0.1.8

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Jul 4, 2024
Copy link
Member

@joostlek joostlek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By the way, pass your discord handle

@joostlek joostlek added this to the 2024.7.1 milestone Jul 4, 2024
@thecode thecode merged commit b406438 into home-assistant:dev Jul 4, 2024
39 checks passed
frenck pushed a commit that referenced this pull request Jul 5, 2024
@frenck frenck mentioned this pull request Jul 5, 2024
@Jordi1990 Jordi1990 deleted the feature/fix-parsing-address branch July 5, 2024 21:36
@github-actions github-actions bot locked and limited conversation to collaborators Jul 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
by-code-owner cherry-picked cla-signed dependency integration: aquacell Quality Scale: No score small-pr PRs with less than 30 lines. smash Indicator this PR is close to finish for merging or closing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AquaCell Failed Setup, will retry: 'Address'
4 participants