Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add climate entity for Legrand 064882 cable outlet #113059

Closed
wants to merge 12 commits into from

Conversation

piitaya
Copy link
Member

@piitaya piitaya commented Mar 11, 2024

Proposed change

Add heat mode select entity for Legrand 064882 cable outlet

CleanShot 2024-03-14 at 11 30 24

CleanShot 2024-03-19 at 21 01 15@2x

Needs zigpy update with this quirk : zigpy/zha-device-handlers#3031

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @dmulcahey, @Adminiuga, @puddly, @TheJulianJES, mind taking a look at this pull request as it has been labeled with an integration (zha) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of zha can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign zha Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@piitaya piitaya force-pushed the zha_legrand_outlet_select branch 3 times, most recently from a44d223 to bf1ce72 Compare March 14, 2024 10:29
@piitaya piitaya changed the title Add heat mode select entity for Legrand 064882 cable outlet Add climate entity for Legrand 064882 cable outlet Mar 14, 2024
Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a merge conflict.

@piitaya
Copy link
Member Author

piitaya commented Mar 15, 2024

@dmulcahey I want to add tests but I don't really know how this works with quirk v2. Do you have an example?

@joostlek
Copy link
Member

Since when do cable outlets have built in heaters

@piitaya
Copy link
Member Author

piitaya commented Mar 19, 2024

@joostlek All electric heaters in France have an additional wire called "fil pilote" to control the preset of the heater. It's a legal obligation to sell a heater in France 😅

Presets are standardized : comfort comfort -1°C comfort -2°C eco frost protection and off.
The Legrand cable outlet has this wire to control any heater.

@joostlek
Copy link
Member

Oh, that's neat to know, nice :)

@piitaya piitaya marked this pull request as ready for review March 22, 2024 16:14
@piitaya
Copy link
Member Author

piitaya commented Mar 22, 2024

Is tests needed? I don't really know how to add tests using quirks v2 😅

@piitaya piitaya force-pushed the zha_legrand_outlet_select branch from 3d98430 to e59951d Compare March 27, 2024 10:39
@emontnemery
Copy link
Contributor

I think this needs tests @piitaya

@emontnemery
Copy link
Contributor

CI is failing and the new code is not covered by tests. Please mark the PR ready for review when that's been addressed 👍

@emontnemery emontnemery marked this pull request as draft May 15, 2024 14:02
@piitaya piitaya force-pushed the zha_legrand_outlet_select branch from e59951d to 014c1b8 Compare May 21, 2024 08:31
@piitaya piitaya force-pushed the zha_legrand_outlet_select branch 2 times, most recently from 5574543 to 6a8226f Compare June 7, 2024 21:57
@piitaya piitaya force-pushed the zha_legrand_outlet_select branch from 6a8226f to ece2676 Compare June 10, 2024 12:55
@dmulcahey
Copy link
Contributor

We have recently migrated the core of ZHA to its own library. Please open a pull request here: https://github.com/zigpy/zha for this. Sorry for the inconvenience and Thanks!

@dmulcahey dmulcahey closed this Jul 10, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jul 11, 2024
@frenck frenck deleted the zha_legrand_outlet_select branch December 24, 2024 08:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants