-
-
Notifications
You must be signed in to change notification settings - Fork 31.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add climate entity for Legrand 064882 cable outlet #113059
Conversation
Hey there @dmulcahey, @Adminiuga, @puddly, @TheJulianJES, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
a44d223
to
bf1ce72
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a merge conflict.
eed799e
to
58602ab
Compare
@dmulcahey I want to add tests but I don't really know how this works with quirk v2. Do you have an example? |
Since when do cable outlets have built in heaters |
@joostlek All electric heaters in France have an additional wire called "fil pilote" to control the preset of the heater. It's a legal obligation to sell a heater in France 😅 Presets are standardized : |
Oh, that's neat to know, nice :) |
Is tests needed? I don't really know how to add tests using quirks v2 😅 |
3d98430
to
e59951d
Compare
I think this needs tests @piitaya |
CI is failing and the new code is not covered by tests. Please mark the PR ready for review when that's been addressed 👍 |
e59951d
to
014c1b8
Compare
5574543
to
6a8226f
Compare
6a8226f
to
ece2676
Compare
We have recently migrated the core of ZHA to its own library. Please open a pull request here: https://github.com/zigpy/zha for this. Sorry for the inconvenience and Thanks! |
Proposed change
Add heat mode select entity for Legrand 064882 cable outlet
Needs zigpy update with this quirk : zigpy/zha-device-handlers#3031
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: