Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add zeroconf support for velux integration #112451

Closed
wants to merge 13 commits into from
Closed

Add zeroconf support for velux integration #112451

wants to merge 13 commits into from

Conversation

pawlizio
Copy link
Contributor

@pawlizio pawlizio commented Mar 5, 2024 •
edited
Loading

Breaking change

Proposed change

Add zeroconf support for velux integration.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented Mar 5, 2024

Hey there @Julius2342, @DeerMaximum, mind taking a look at this pull request as it has been labeled with an integration (velux) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of velux can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign velux Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@pawlizio pawlizio mentioned this pull request Mar 6, 2024
Closed
@pawlizio pawlizio force-pushed the velux_zeroconf branch 3 times, most recently from 8f1c9bd to 732fca5 Compare March 7, 2024 21:36
@pawlizio pawlizio marked this pull request as ready for review March 7, 2024 21:43
@pawlizio pawlizio mentioned this pull request Apr 12, 2024
Merged
20 tasks
@emontnemery
Copy link
Contributor

@pawlizio the PR has merge conflicts, can you fix them?

emontnemery
emontnemery reviewed May 16, 2024
View reviewed changes
Copy link
Contributor

@emontnemery emontnemery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment on the added functionality, I'd like some feedback from other developers before proceeding with the review

homeassistant/components/velux/config_flow.py
data_schema = self.add_suggested_values_to_schema(DATA_SCHEMA, user_input)
if not self.hosts:
aiozc = await zeroconf.async_get_async_instance(self.hass)
vd: VeluxDiscovery = VeluxDiscovery(zeroconf=aiozc)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about this, do we really need both user triggered and automatic discovery?
Maybe we could add functionality to the Home Assistant zeroconf integration which allows fetching services already discovered for a services, similar to what we support for bluetooth:

core/homeassistant/components/dormakaba_dkey/config_flow.py

Line 63 in 4ff6453

for discovery in async_discovered_service_info(self.hass):

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think adding that to zeroconf would be helpful long term. Right now users tend to ignore discoveries and than can’t find the integration and than open issues if they have no way to add it manually once it’s ignored. If they do discover that and unignore it, a restart is generally required to find it again.

When we solve these issues we probably don’t need manual adding anymore but we are still a ways off from a solution there. In the mean time it makes sense to implement manual adding via a user flow

Copy link
Member

@frenck frenck Jul 7, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO, we shouldn't add this here; and instead solve the issue at hand in core instead.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. This PR could drive the needed change in the zeroconf integration. @pawlizio Is this something you could look into? You can contact me on Discord if it's not clear where to start.

@frenck frenck marked this pull request as draft July 7, 2024 21:06
@frenck
Copy link
Member

frenck commented Sep 27, 2024

Because there hasn't been any activity on this PR for quite some time now, I've decided to close it for being stale.

Feel free to re-open this PR when you are ready to pick up work on it again 👍

../Frenck

@frenck frenck closed this Sep 27, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Sep 28, 2024
@home-assistant home-assistant unlocked this conversation Jan 5, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Jan 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DeerMaximum DeerMaximum DeerMaximum left review comments

@emontnemery emontnemery emontnemery left review comments

@bdraco bdraco bdraco left review comments

@frenck frenck frenck left review comments

Assignees
No one assigned
Labels
cla-signed has-tests integration: velux Quality Scale: No score
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pawlizio @emontnemery @frenck @bdraco @DeerMaximum